You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FOUR-34384 Migrate ProcessMaker Core skills to Skills repository - #9162
Core still bundles 33 MCP skill markdown files and a system-skill catalog (McpSystemSkills) that the seeder writes into the mcp.skills setting. The same guidance now lives in the Skills repository (ProcessMaker/skills), which MCP clients install directly. Keeping both copies drifts, and the MCP server instructions still reference slugs that no longer resolve.
Solution
Delete ProcessMaker/Mcp/skills/*.md and ProcessMaker/Mcp/McpSystemSkills.php.
Rename McpSystemSkillsSeeder to McpSettingsSeeder. It creates the mcp.system_prompt and mcp.skills settings if missing, stops upserting system skills, and leaves custom skills untouched. DatabaseSeeder and 2026_11_06_143900_add_mcp_settings_menu use the new name.
Add upgrade 2026_11_11_190000_remove_mcp_system_skills, which removes stored entries with system: true, an id prefixed mcp-system-, or the legacy id skill-1793976475109-l6si55 from mcp.skills. Custom skills are kept, it is idempotent, and down() is a no-op.
Replace hard-coded Core slugs in the ScreenServer, ProcessServer, DataConnectorsServer, and FlowGenieServer instructions, the six affected tool descriptions, the ScreenConfigValidator warning, and ProcessPlanner with pointers to the matching pm4-* skills.
Rewrite the MCP tests: ProcessServerTest, DataConnectorsServerTest, and FlowGenieServerTest use custom scoped skills; McpSystemSkillsSeederTest is replaced by McpSettingsSeederTest; RemoveMcpSystemSkillsTest covers the purge.
Not changed: the system flag in McpGuidance.php and the McpSkills.vue UI still exist. They are now unused for built-in skills and can be removed in a follow-up.
How to Test
Run php artisan test --filter='Mcp|RemoveMcpSystemSkills'.
On an instance with the old system skills in mcp.skills, run php artisan migrate. Confirm that only custom skills remain in the mcp.skills setting.
Run php artisan db:seed --class=Database\\Seeders\\McpSettingsSeeder twice. Confirm the settings exist once and custom skills are unchanged.
Call get-mcp-guidance from an MCP client. Confirm the response lists only custom skills and the instructions point to the Skills repository.
Medium Risk
Upgrades purge built-in skills from settings and MCP instructions now depend on the external Skills repo—agents that only used get-mcp-skill for platform slugs will need the new install path until clients adopt it.
Overview Built-in MCP skill content is removed from core — McpSystemSkills, all ProcessMaker/Mcp/skills/*.md files, and McpSystemSkillsSeeder are deleted. Fresh installs and seeding now use McpSettingsSeeder, which only ensures mcp.system_prompt and mcp.skills exist with an updated helper pointing agents to npx skills add processmaker/skills and pm4-* skills instead of seeding platform markdown into the database.
An upgrade 2026_11_11_190000_remove_mcp_system_skills strips stored system entries from mcp.skills (ids prefixed mcp-system-, system: true, or legacy skill-1793976475109-l6si55) while keeping tenant custom skills. DatabaseSeeder and the MCP settings menu migration call the new seeder.
MCP surfaces now reference the external repo — ScreenServer, ProcessServer, DataConnectorsServer, FlowGenieServer instructions, six tool descriptions, ScreenConfigValidator, and ProcessPlanner no longer cite local slugs like screen-creation-rules / process-creation-rules; they direct clients to pm4-screen, pm4-process, pm4-data-connector, pm4-collection, and pm4-flow-genie.
Tests are aligned with custom scoped skills only, plus new coverage for McpSettingsSeeder and the removal upgrade.
Reviewed by Cursor Bugbot for commit c5aff8d. Bugbot is set up for automated code reviews on this repo. Configure here.
devmiguelangel
changed the title
refactor(mcp): remove bundled MCP skills in favor of skills repo
FOUR-34384 Migrate ProcessMaker Core skills to Skills repository
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Core still bundles 33 MCP skill markdown files and a system-skill catalog (
McpSystemSkills) that the seeder writes into themcp.skillssetting. The same guidance now lives in the Skills repository (ProcessMaker/skills), which MCP clients install directly. Keeping both copies drifts, and the MCP server instructions still reference slugs that no longer resolve.Solution
ProcessMaker/Mcp/skills/*.mdandProcessMaker/Mcp/McpSystemSkills.php.McpSystemSkillsSeedertoMcpSettingsSeeder. It creates themcp.system_promptandmcp.skillssettings if missing, stops upserting system skills, and leaves custom skills untouched.DatabaseSeederand2026_11_06_143900_add_mcp_settings_menuuse the new name.2026_11_11_190000_remove_mcp_system_skills, which removes stored entries withsystem: true, an id prefixedmcp-system-, or the legacy idskill-1793976475109-l6si55frommcp.skills. Custom skills are kept, it is idempotent, anddown()is a no-op.ScreenServer,ProcessServer,DataConnectorsServer, andFlowGenieServerinstructions, the six affected tool descriptions, theScreenConfigValidatorwarning, andProcessPlannerwith pointers to the matchingpm4-*skills.ProcessServerTest,DataConnectorsServerTest, andFlowGenieServerTestuse custom scoped skills;McpSystemSkillsSeederTestis replaced byMcpSettingsSeederTest;RemoveMcpSystemSkillsTestcovers the purge.Not changed: the
systemflag inMcpGuidance.phpand theMcpSkills.vueUI still exist. They are now unused for built-in skills and can be removed in a follow-up.How to Test
php artisan test --filter='Mcp|RemoveMcpSystemSkills'.mcp.skills, runphp artisan migrate. Confirm that only custom skills remain in themcp.skillssetting.php artisan db:seed --class=Database\\Seeders\\McpSettingsSeedertwice. Confirm the settings exist once and custom skills are unchanged.get-mcp-guidancefrom an MCP client. Confirm the response lists only custom skills and the instructions point to the Skills repository.Related Tickets & Packages
FOUR-34384
https://github.com/ProcessMaker/skills/pull/54
Code Review Checklist
ci:nayra:FOUR-34376